Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: change Flags to PersistentFlags #958

Closed

Conversation

faycheng
Copy link
Contributor

Ⅰ. Describe what this PR did

change Flags to PersistentFlags

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Daemon config file is invalid while using Flags.

> cat /etc/pouch/config.json
{"debug": true}
> pouchd
ERRO[0000] failed to load daemon file: unknow flags: debug

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Mar 24, 2018
@codecov-io
Copy link

codecov-io commented Mar 24, 2018

Codecov Report

Merging #958 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   13.06%   13.06%           
=======================================
  Files         123      123           
  Lines        8235     8235           
=======================================
  Hits         1076     1076           
  Misses       7063     7063           
  Partials       96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979666b...4413251. Read the comment docs.

@allencloud allencloud changed the title bugfix:change Flags to PersistentFlags bugfix: change Flags to PersistentFlags Mar 24, 2018
@allencloud
Copy link
Collaborator

Could you help to take a look at this? @HusterWan
Also cc @yyb196 Maybe it is related to the issue we discussed several days ago.

@HusterWan
Copy link
Contributor

cat /etc/pouch/config.json
{"debug": true}
pouchd
ERRO[0000] failed to load daemon file: unknow flags: debug

@faycheng i cannot replay this error, i think this problem maybe caused by PR #917 , we have revert this code.

so maybe you should rebase you local code with upstream/master, and try again.

if you can still occur this error, please let me know, thanks a lot.

@faycheng
Copy link
Contributor Author

@HusterWan you are right.soon after this error raised, i wished only to fix it and i didn't find it reverted.i feel deeply ashamed for creating this pr. sorry

@faycheng faycheng closed this Mar 24, 2018
@allencloud
Copy link
Collaborator

That is all right. Never mind. We sincerely appreciate your work. Feel free to tell us if you meet any question here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants