Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make swagger version locked 0.12.0 rather than lastet #881

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

allencloud
Copy link
Collaborator

@allencloud allencloud commented Mar 12, 2018

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

In the original Dockerfile, we use command go get -u github.com/go-swagger/go-swagger/cmd/swagger to install swagger binary which is already from the newest code. And we cannot guarantee the quality of the latest code ever.

As we had a rule in hack/generate-swagger-models.sh that we should use swagger 0.12.0 to meet our requirement, we should always download a binary which is locked to version swagger 0.12.0.

As a result, I change the command to be wget --quiet -O /bin/swagger https://github.com/go-swagger/go-swagger/releases/download/0.12.0/swagger_linux_amd64.

Ⅱ. Does this pull request fix one issue?

This issue happens almost in all pull requests which we have modified the swagger.yml.
Like #879, #878, #875 and so on

Ⅲ. Describe how you did it

change a command to finish this

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Mar 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #881 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #881   +/-   ##
=======================================
  Coverage   14.62%   14.62%           
=======================================
  Files         115      115           
  Lines        6940     6940           
=======================================
  Hits         1015     1015           
  Misses       5839     5839           
  Partials       86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c6ffb...8a4543f. Read the comment docs.

@allencloud
Copy link
Collaborator Author

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 13, 2018
@allencloud allencloud merged commit 10d8a94 into AliyunContainerService:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants