fix: make swagger version locked 0.12.0 rather than lastet #881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
In the original Dockerfile, we use command
go get -u github.com/go-swagger/go-swagger/cmd/swagger
to install swagger binary which is already from the newest code. And we cannot guarantee the quality of the latest code ever.As we had a rule in
hack/generate-swagger-models.sh
that we should use swagger 0.12.0 to meet our requirement, we should always download a binary which is locked to version swagger 0.12.0.As a result, I change the command to be
wget --quiet -O /bin/swagger https://github.com/go-swagger/go-swagger/releases/download/0.12.0/swagger_linux_amd64
.Ⅱ. Does this pull request fix one issue?
This issue happens almost in all pull requests which we have modified the swagger.yml.
Like #879, #878, #875 and so on
Ⅲ. Describe how you did it
change a command to finish this
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews