-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add exec inspect api in daemon side #875
feature: add exec inspect api in daemon side #875
Conversation
7e79155
to
1d29ca9
Compare
@allencloud what's status of this PR, can you rebase this pr? thanks a lot |
1d29ca9
to
ed451bd
Compare
ed451bd
to
00dbbd3
Compare
@allencloud We should fix and merge this pr ASAP, our deployment system relay on this interface to check the result of pouch exec, in the health checking case. |
@yyb196 |
00dbbd3
to
50241a7
Compare
13bf84d
to
4f1affa
Compare
Signed-off-by: Allen Sun <[email protected]>
4f1affa
to
8fa7281
Compare
ping @allencloud CI fails according integration system. If this is flaky test, welcome to track this with profiling an issue. build url: https://travis-ci.org/alibaba/pouch/builds/364133108 |
LGTM, but we need to make some change for exec of cri manager. I'll fix it soon :) @allencloud |
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
This PR implements
GET /exec/{id}/json
just in daemon side.I have found that in moby api v1.24, the daemon side has returned a full type of
ContainerExecInspect
, but in client side of engine-api, it only takes advantages of four fields:Since there is possibility that user would call this API several times, so I removed
execConfig.exitCh
in structContainerExecConfig
.So in this PR, I only add these four fields in daemon side.
Ⅱ. Does this pull request fix one issue?
fixes #864
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none