feature: add Close function for boltdb backend #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
+ Coverage 68.4% 68.45% +0.04%
==========================================
Files 271 271
Lines 18263 18269 +6
==========================================
+ Hits 12493 12506 +13
+ Misses 4347 4345 -2
+ Partials 1423 1418 -5
|
zhuangqh
reviewed
Oct 31, 2018
| @@ -201,6 +202,18 @@ func TestBoltdbRemove(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestBoltdbClose(t *testing.T) { | |||
| if err := boltdbStore.Shutdown(); err != nil { | |||
There was a problem hiding this comment.
Why did you just immediately shutdown the boltdbStore? I could not find the initialization code of boltdbStore.
Is this test depends on other test to initialize the boltdbStore? Is it reasonable?
There was a problem hiding this comment.
Just stay with the origin test cases, but i think your advice is reasonable, i will update it
rudyfly
reviewed
Oct 31, 2018
| @@ -270,3 +270,8 @@ func (s *Store) KeysWithPrefix(prefix string) ([]string, error) { | |||
| func (s *Store) Path(key string) string { | |||
| return s.backend.Path(key) | |||
| } | |||
|
|
|||
| // Shutdown releases all resources used by the backend | |||
| func (s *Store) Shutdown() error { | |||
There was a problem hiding this comment.
Where to call the function Shutdown？
There was a problem hiding this comment.
I need it in d2p-migrator :)
HusterWan
force-pushed
the
zr/volume-store
branch
from
f16d564 to
73d6e7c
Compare
HusterWan
force-pushed
the
zr/volume-store
branch
2 times, most recently
from
25bc6a3 to
42c564b
Compare
zhuangqh
reviewed
Nov 1, 2018
pkg/meta/store_test.go
Outdated
| func ensureFileNotExist(file string) error { | ||
| _, err := os.Stat(file) | ||
| if err == nil { | ||
| os.Remove(file) |
There was a problem hiding this comment.
Actually, file is a directory path, using os.RemoveAll instead.
There was a problem hiding this comment.
I am afraid, file is a file path
pkg/meta/store_test.go
Outdated
| if err := ensureFileNotExist(dbFile); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| defer ensureFileNotExist(dbFile) |
There was a problem hiding this comment.
What about creating a test wrapper? like
func storeTestWrapper(t *testing.T, name string, test func(*Store)) {
dbDir := path.Join("/tmp", utils.RandString(8, name, ""))
if err := ensureFileNotExist(dbDir); err != nil {
t.Fatal(err)
}
defer ensureFileNotExist(dbDir)
s, err := initLocalStore(dbDir)
if err != nil {
t.Fatal(err)
}
test(s)
}func TestGet(t *testing.T) {
storeTestWrapper(t, "TestGet", func(s *Store) {
// xxx
})
}Don't repeat yourself
Signed-off-by: Michael Wan <[email protected]>
HusterWan
force-pushed
the
zr/volume-store
branch
from
42c564b to
788156a
Compare
|
LGTM |
1 similar comment
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan [email protected]
Ⅰ. Describe what this PR did
When testing d2p-migrator, I found I need close the
boltdbstore after used, so that thepouchdcan take charge of the volume store.So I add a
Shutdownfunction for theStoreⅡ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
add
TestBoltdbClosecaseⅣ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none