feature: add Close func for Store backend

Signed-off-by: Michael Wan <[email protected]>

pkg/meta/backend.go

@@ -24,6 +24,10 @@ type Backend interface {
 
 	// Path returns the path with the specified key.
 	Path(key string) string
+
+	// Close releases all resources used by the store
+	// It does not make any changes to store.
+	Close() error
 }
 
 // Register registers a backend to be daemon's store.

pkg/meta/boltdb.go

@@ -160,3 +160,9 @@ func (b *bolt) List(bucket string) ([][]byte, error) {
 
 	return values, err
 }
+
+// Close releases all database resources.
+// All transactions must be closed before closing the database.
+func (b *bolt) Close() error {
+	return b.db.Close()
+}

pkg/meta/local.go

@@ -177,6 +177,11 @@ func (s *localStore) Keys(fileName string) ([]string, error) {
 	return keys, nil
 }
 
+// Close do nothing in local store
+func (s *localStore) Close() error {
+	return nil
+}
+
 func mkdirIfNotExist(dir string) error {
 	if _, err := os.Stat(dir); err != nil {
 		if os.IsNotExist(err) {

pkg/meta/store.go

@@ -270,3 +270,8 @@ func (s *Store) KeysWithPrefix(prefix string) ([]string, error) {
 func (s *Store) Path(key string) string {
 	return s.backend.Path(key)
 }
+
+// Shutdown releases all resources used by the backend
+func (s *Store) Shutdown() error {
+	return s.backend.Close()
+}

pkg/meta/store_test.go

@@ -1,6 +1,7 @@
 package meta
 
 import (
+	"fmt"
 	"reflect"
 	"testing"
 )
@@ -201,6 +202,18 @@ func TestBoltdbRemove(t *testing.T) {
 	}
 }
 
+func TestBoltdbClose(t *testing.T) {
+	if err := boltdbStore.Shutdown(); err != nil {
+		t.Fatal(err)
+	}
+
+	// test List again, should occur error here
+	_, err := boltdbStore.List()
+	if err == nil {
+		t.Fatal(fmt.Errorf("still can visit the boltdb after execute close db action"))
+	}
+}
+
 type Demo4 struct {
 	A int
 	B string