refactor: use return fast to make code readable #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2373 +/- ##
=========================================
+ Coverage 64.14% 68.2% +4.06%
=========================================
Files 275 265 -10
Lines 18261 18213 -48
=========================================
+ Hits 11713 12422 +709
+ Misses 5275 4361 -914
- Partials 1273 1430 +157
|
fengzixu
reviewed
Oct 28, 2018
pkg/netutils/interface.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if memberOf(ip, family) { |
There was a problem hiding this comment.
According to the logic, I consider that there is an alternative method which I usually used to write:
if ! memberOf(ip, family) {
glog.V(4).Infof("%v is not an IPv%d address", ip, int(family))
continue
}
if ip.IsGlobalUnicast() {
glog.V(4).Infof("IP found %v", ip)
return ip, nil
}
glog.V(4).Infof("Non-global unicast address found %v", ip)
I recommend this code style because it can deduce the nested level, but it seems like that the readability perhaps has a decrease.
There was a problem hiding this comment.
That makes sense. @fengzixu
There was a problem hiding this comment.
LGTM. Could you also refactor memberOf to fast return pattern ?
There was a problem hiding this comment.
@fengzixu Yes, it is more idiomatic 👍
allencloud
force-pushed
the
return-fast
branch
from
fedc003 to
15f4d74
Compare
Signed-off-by: Allen Sun <[email protected]>
allencloud
force-pushed
the
return-fast
branch
from
15f4d74 to
33c8abd
Compare
|
Thanks for your review. I have updated that part. @xiaoxubeii @zhuangqh @fengzixu |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
use return fast to make code readable.
When I was reviewing pr #2367. I found that some code should be refactored. While the package
pkg/netutilsis imported by @YaoZengzeng in pr #2040.And I found that in this package, log package is using
"github.com/golang/glog"ratherlogrus. Do we need to make this package to use logrus? @YaoZengzengⅡ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none