bugfix: move function getListener() to pkg/net/listener.go #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
reviewed
Aug 2, 2018
pkg/net/listener.go
Outdated
| func GetListener(addr string, tlsConfig *tls.Config) (net.Listener, error) { | ||
| addrParts := strings.SplitN(addr, "://", 2) | ||
| if len(addrParts) != 2 { | ||
| return nil, fmt.Errorf("invalid listening address: %s", addr) |
There was a problem hiding this comment.
I think in a common function, we could give more details about the error message. How about adding like this:
fmt.Errorf("invalid listening address %s: address must be [protocol]://[address]", addr)
YaoZengzeng
force-pushed
the
net-tools
branch
3 times, most recently
from
06214a2 to
efed1e5
Compare
YaoZengzeng
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2040 +/- ##
===========================================
+ Coverage 51.18% 63.78% +12.59%
===========================================
Files 200 201 +1
Lines 15531 15527 -4
===========================================
+ Hits 7950 9904 +1954
+ Misses 6513 4385 -2128
- Partials 1068 1238 +170
|
YaoZengzeng
force-pushed
the
net-tools
branch
6 times, most recently
from
7e8a6be to
ead57c2
Compare
YaoZengzeng
changed the title
|
@fuweid PTAL. |
fuweid
reviewed
Aug 3, 2018
pkg/netutils/listener_test.go
Outdated
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| _, err := GetListener(tt.args.addr, nil) |
There was a problem hiding this comment.
could we close it if the case pass?
Signed-off-by: YaoZengzeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews