Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BJ266-4: Add unit-test for apis/opts/ports.go, fix #1906 #1976

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

devily
Copy link
Contributor

@devily devily commented Jul 31, 2018

Ⅰ. Describe what this PR did

New ports and expose ports interface.

Ⅱ. Does this pull request fix one issue?

fix #1906

Ⅲ. Describe how you did it

Add one correct test case and two incorrect test case.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

@devily Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @devily
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1976 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
+ Coverage   63.31%   63.41%   +0.09%     
==========================================
  Files         200      200              
  Lines       15522    15522              
==========================================
+ Hits         9828     9843      +15     
+ Misses       4455     4437      -18     
- Partials     1239     1242       +3
Flag Coverage Δ
#criv1alpha1test 33.82% <ø> (-0.04%) ⬇️
#criv1alpha2test 34.28% <ø> (ø) ⬆️
#integrationtest 38.42% <ø> (-0.01%) ⬇️
#unittest 20.99% <ø> (+0.13%) ⬆️
Impacted Files Coverage Δ
ctrd/watch.go 72.72% <0%> (-3.04%) ⬇️
daemon/mgr/container.go 53.85% <0%> (-0.16%) ⬇️
cri/stream/httpstream/spdy/upgrade.go 60% <0%> (+5.71%) ⬆️
apis/opts/ports.go 73.91% <0%> (+73.91%) ⬆️

@fuweid fuweid merged commit 703b26a into AliyunContainerService:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for apis/opts/ports.go
5 participants