Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for modifyContainerNamespaceOptions #1945

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

MarkLux
Copy link
Contributor

@MarkLux MarkLux commented Jul 31, 2018

Ⅰ. Describe what this PR did

add unit test for modifyContainerNamespaceOptions

Ⅱ. Does this pull request fix one issue?

fix #1911

Ⅲ. Describe how you did it

add input test cases with normal and nil

Ⅳ. Describe how to verify it

run go test -v -run modifyContainerNamespaceOptions under package v1alpha1

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@MarkLux Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @MarkLux
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1945 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
- Coverage    63.3%   63.23%   -0.07%     
==========================================
  Files         200      200              
  Lines       15521    15521              
==========================================
- Hits         9825     9815      -10     
- Misses       4456     4464       +8     
- Partials     1240     1242       +2
Flag Coverage Δ
#criv1alpha1test 33.79% <ø> (+0.04%) ⬆️
#criv1alpha2test 34.21% <ø> (-0.1%) ⬇️
#integrationtest 38.4% <ø> (ø) ⬆️
#unittest 21.05% <ø> (+0.19%) ⬆️
Impacted Files Coverage Δ
cri/stream/portforward/httpstream.go 69.16% <0%> (-6.67%) ⬇️
cri/stream/runtime.go 71.01% <0%> (-2.9%) ⬇️
cri/v1alpha2/cri.go 66.31% <0%> (-0.18%) ⬇️
cri/v1alpha1/cri.go 65.58% <0%> (+0.18%) ⬆️

@YaoZengzeng
Copy link
Contributor

LGTM

Thanks for your work :)

@YaoZengzeng YaoZengzeng merged commit c38392c into AliyunContainerService:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for modifyContainerNamespaceOptions
4 participants