Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boa: don't set PYTHONHOME #610

Closed
wants to merge 1 commit into from
Closed

boa: don't set PYTHONHOME #610

wants to merge 1 commit into from

Conversation

yorkie
Copy link
Member

@yorkie yorkie commented Oct 10, 2020

As #582 (comment) pointed out, this causes spawning with incompatible python(like python2) won't work.

@yorkie yorkie added the boa Python related issues label Oct 10, 2020
@yorkie yorkie requested review from FeelyChau and WenheLI October 10, 2020 15:11
@WenheLI
Copy link
Collaborator

WenheLI commented Oct 12, 2020

The CI fails due to unresolved $PYTHONHOME seems like we still need to set it manually?

@yorkie
Copy link
Member Author

yorkie commented Oct 12, 2020

The CI fails due to unresolved $PYTHONHOME seems like we still need to set it manually?

Yea, we have to manually remove PYTHONHOME when we want to spawn to use python2.

@yorkie yorkie closed this Oct 12, 2020
@yorkie yorkie deleted the fix/boa-remove-env-set branch October 12, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeelyChau FeelyChau Awaiting requested review from FeelyChau

@WenheLI WenheLI Awaiting requested review from WenheLI

Assignees
No one assigned
Labels
boa Python related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorkie @WenheLI