Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.2 #81

Merged
merged 5 commits into from
Sep 27, 2018
Merged

0.2.2 #81

merged 5 commits into from
Sep 27, 2018

Conversation

nkorange
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

  1. [ISSUE Support deregistering the last instance of service #66] FIx deregister last instance failed error.
  2. [ISSUE url '/nacos/v1/ns/instances' change to '/nacos/v1/ns/instance/list' #78] Fix url pattern error.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@xuechaos xuechaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 0.2.1

@xuechaos xuechaos merged commit 0b5add2 into master Sep 27, 2018
realJackSun pushed a commit to realJackSun/nacos that referenced this pull request Mar 31, 2021
add SEO header for the what-is-nacos.md file
@sunqb sunqb mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants