Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#5697]Add new indicator for core module, especially Jraft and Distro protocal. #7003

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Conversation

Holdonbei
Copy link

@Holdonbei Holdonbei commented Sep 28, 2021

What is the purpose of the change

Add new indicator for core module, especially Jraft and Distro protocal.

Brief changelog

1.Remove MetricsMonitor in config module and use MetricsManager to record metrics, which is also do in core and naming module.

2.In order to make MetricsConstant more easier, this pr delete prefix in MetricsConstant.

3.Add Jraft metrics.
Metrics related to Jraft ars below:

  • jraft_append_logs_count :the total number of RAFT logs written.
  • jraft_replicate_entries_count :the total number of replicate logs from leader to folllower.
  • jraft_next_index :the log index that is coping.
  • jraft_log_lags :the total numer of delay log.
  • jraft_pre_vote_count :the total number of pre vote times.
  • jraft_request_vote_count :the total number of request vote times.

4.Add Distro metrics.
Metrics related to Distro ars below:

  • distro_verify{resource_type=resourceType, target_server=targetServer, success=true}. It counts verifySuccess times.
  • distro_verify{resource_type=resourceType, target_server=targetServer, success=false}. It counts verifyFailed times.
  • distro_sync{resource_type=resourceType, target_server=targetServer, success=true}. It counts syncSuccess times.
  • distro_sync{resource_type=resourceType, target_server=targetServer, success=false}. It counts syncFailed times.

Verifying this change

Checked.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

* delete MetricsMonitor.java in core module.

* delete MetricsMonitor.java in config module.

* remove some unnecessary code in MetricsMonitor.java from naming module.

* add a NacosMetersReporter which is aimed to transfer JRaft metrics into micrometer metrics.

* fix code style.

* delete unnecessary code and add a groupName String for NacosMetersReporter.java.

* delete unnecessary notes.

* add some JRaft metrics into MetricsManger.

* fix code style error.

* delete append-logs and replicate-entries timer, nacos only collect theirs times.

* add prefix for JRaft metrics.

* add distro metrics in core module.

* fix code style.

* rename gaugesMap into gauges, countersMap into counters and timersMap into timers.
@haoyann haoyann self-assigned this Sep 28, 2021
@haoyann haoyann self-requested a review September 28, 2021 03:52
Copy link
Collaborator

@haoyann haoyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haoyann haoyann merged commit 919cfd2 into alibaba:summer2021_issue#5697 Sep 30, 2021
@haoyann haoyann added the Summer label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants