Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOR 5771 config impl] improve the code quality of nacos-client. #5980

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

brotherlu-xcq
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

improve the code quality of nacos-client, directory config impl
For #5771

Brief changelog

  • simple the judge logic
  • constant export
  • chinese javadoc translate
  • change the position of variable

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion
Copy link
Collaborator

CI problem need be fixed

@KomachiSion KomachiSion merged commit 1daa598 into alibaba:develop Jun 9, 2021
@KomachiSion KomachiSion added this to the 2.0.2 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants