-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code quality][nacos-address]improve the code of ServiceManager.java #5919
[code quality][nacos-address]improve the code of ServiceManager.java #5919
Conversation
Please fix the cla problem first |
done |
Can you describe why you do refactor like this? I think this change need to be discuss. |
主要是优化了两个锁,使逻辑简单清晰一点。 |
} | ||
} | ||
serviceMap.get(service.getNamespaceId()).putIfAbsent(service.getName(), service); | ||
serviceMap.putIfAbsent(service.getNamespaceId(), new ConcurrentSkipListMap<>()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the doc, the method will return the previous value associated with the specified key
.
So will it throw NPE when called first time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i wil fix it later
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.