[code quality][nacos-address]improve the code of ServiceManager.java #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please fix the cla problem first |
done |
|
Can you describe why you do refactor like this? I think this change need to be discuss. |
主要是优化了两个锁，使逻辑简单清晰一点。 |
KomachiSion
requested changes
Jun 9, 2021
| } | ||
| } | ||
| serviceMap.get(service.getNamespaceId()).putIfAbsent(service.getName(), service); | ||
| serviceMap.putIfAbsent(service.getNamespaceId(), new ConcurrentSkipListMap<>()) |
There was a problem hiding this comment.
From the doc, the method will return the previous value associated with the specified key.
So will it throw NPE when called first time?
There was a problem hiding this comment.
yes, i wil fix it later
KomachiSion
approved these changes
Jun 16, 2021
KomachiSion
added
kind/refactor
and removed
pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.