Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5037]add ut for package com.alibaba.nacos.client.config.utils #5050

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Mar 8, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix [ISSUE #5037]add ut for package com.alibaba.nacos.client.config.utils
line coverage 82%

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (validate) on project nacos-client: Failed during checkstyle execution: There are 2 errors reported by Checkstyle 8.29 with style/NacosCheckStyle.xml ruleset.

Please check it

@KomachiSion KomachiSion added this to the 2.0.0 milestone Mar 11, 2021
@KomachiSion KomachiSion merged commit 711afc7 into alibaba:feature_support_grpc_core Mar 11, 2021
@shalk shalk deleted the feature_support_grpc_core_ut-client-config-utils-1 branch March 17, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants