Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5034] add ut for package com.alibaba.nacos.client.config.http #5048

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Mar 8, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix [ISSUE #5034] add ut for package com.alibaba.nacos.client.config.http

line coverage 59%

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

realJackSun
realJackSun approved these changes Mar 10, 2021
Copy link
Collaborator

@realJackSun realJackSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测不应该走网络,应当是纯粹内存操作。个人认为正确的做法是,Mock出来一个NacosRestTemplate NACOS_RESTTEMPLATE(完全搞成内存操作),通过反射塞进ServerHTTPAgent类里面。然后,运行httpGet,assert一下NACOS_RESTTEMPLATE.get被调用过。

final HttpRestResult<String> result = serverHttpAgent
.httpGet("/get", new HashMap<String, String>(), new HashMap<String, String>(), "UTF-8", 5000);

Assert.assertEquals(200, result.getCode());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个返回200在进行单测的时候并不能保证吧,因为服务端可能都没有启动起来。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当前地址是 https://httpbin.org/ 托管在github page上,长期运行的

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip this case first if this static final field is hard to mock.

@shalk
Copy link
Contributor Author

shalk commented Mar 11, 2021

单测不应该走网络,应当是纯粹内存操作。个人认为正确的做法是,Mock出来一个NacosRestTemplate NACOS_RESTTEMPLATE(完全搞成内存操作),通过反射塞进ServerHTTPAgent类里面。然后,运行httpGet,assert一下NACOS_RESTTEMPLATE.get被调用过。

i will remove this

final HttpRestResult<String> result = serverHttpAgent
.httpGet("/get", new HashMap<String, String>(), new HashMap<String, String>(), "UTF-8", 5000);

Assert.assertEquals(200, result.getCode());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip this case first if this static final field is hard to mock.

@KomachiSion KomachiSion added this to the 2.0.0 milestone Mar 15, 2021
@KomachiSion KomachiSion merged commit 5b99b7d into alibaba:feature_support_grpc_core Mar 15, 2021
@shalk shalk deleted the feature_support_grpc_core-ut-client-config-http-1 branch March 17, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants