[ISSUE #5034] add ut for package com.alibaba.nacos.client.config.http #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realJackSun
requested changes
Mar 10, 2021
| final HttpRestResult<String> result = serverHttpAgent | ||
| .httpGet("/get", new HashMap<String, String>(), new HashMap<String, String>(), "UTF-8", 5000); | ||
|
|
||
| Assert.assertEquals(200, result.getCode()); |
There was a problem hiding this comment.
这个返回200在进行单测的时候并不能保证吧，因为服务端可能都没有启动起来。
There was a problem hiding this comment.
当前地址是 https://httpbin.org/ 托管在github page上，长期运行的
There was a problem hiding this comment.
Skip this case first if this static final field is hard to mock.
i will remove this |
KomachiSion
requested changes
Mar 11, 2021
| final HttpRestResult<String> result = serverHttpAgent | ||
| .httpGet("/get", new HashMap<String, String>(), new HashMap<String, String>(), "UTF-8", 5000); | ||
|
|
||
| Assert.assertEquals(200, result.getCode()); |
There was a problem hiding this comment.
Skip this case first if this static final field is hard to mock.
KomachiSion
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix [ISSUE #5034] add ut for package com.alibaba.nacos.client.config.http
line coverage 59%
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.