[ISSUE-#4450] Fix memberAddressInfos not right problem when memberChange #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuntaojun
reviewed
Dec 11, 2020
core/src/main/java/com/alibaba/nacos/core/cluster/ServerMemberManager.java
Show resolved
Hide resolved
|
我看现在如果在opsConteoller那里直接下线露某个节点，就会到这里来，这里不判断state的话，就会把所有的加进去了
发自我的iPhone
…------------------ Original ------------------
From: liaochuntao <[email protected]>
Date: Fri,Dec 11,2020 11:35 AM
To: alibaba/nacos <[email protected]>
Cc: 赵延 <[email protected]>, Author <[email protected]>
Subject: Re: [alibaba/nacos] [ISSUE-#4450] Fix memberAddressInfos not right problem when memberChange (#4451)
@chuntaojun commented on this pull request.
In core/src/main/java/com/alibaba/nacos/core/cluster/ServerMemberManager.java:
> @@ -308,7 +308,9 @@ synchronized boolean memberChange(Collection<Member> members) { // Ensure that the node is created only once tmpMap.put(address, member); - tmpAddressInfo.add(address); + if (NodeState.UP.equals(member.getState())) {
健康节点的加入移除，不是在这个方法处理的，而是在update
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
chuntaojun
approved these changes
Dec 11, 2020
KomachiSion
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix-#4450