[ISSUE-#4258] Fix wrong path when -Dspring.config.location not set #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuntaojun
reviewed
Nov 18, 2020
chuntaojun
previously approved these changes
Nov 19, 2020
chuntaojun
previously approved these changes
Nov 19, 2020
Maijh97
reviewed
Nov 19, 2020
Maijh97
approved these changes
Nov 19, 2020
I think it's CI mistake |
….properties -> classpath:/application.properties
chuntaojun
reviewed
Nov 20, 2020
chuntaojun
previously approved these changes
Nov 20, 2020
Maijh97
previously approved these changes
Nov 22, 2020
KomachiSion
requested changes
Nov 23, 2020
Maijh97
approved these changes
Nov 23, 2020
chuntaojun
approved these changes
Nov 23, 2020
KomachiSion
approved these changes
Nov 25, 2020
KomachiSion
added a commit
that referenced
this pull request
Dec 3, 2020
* [ISSUE-#4262] Fix public namespace permission problem (#4273) * fix public namespace permission problem * move NamespaceUtilTest to common module * [ISSUE-#4232] Use EnvUtil to replace ApplicationUtils about env operation (#4281) * use EnvUtil to replace ApplicationUtils about env operation * remove unuse import * remove unuse import * remove profile usage * [ISSUE-#4294] Use EnvUtils.setEnvironment to replace ApplicationUtils.injectEnvironment (#4295) * use EnvUtils.setEnvironment to replace ApplicationUtils.injectEnvironment. * remove unuseful import * remove unuseful import * refactor: refactor issue #4291 (#4292) * remove env operation code in ApplicationUtils (#4298) * refactor issue #4275 (#4299) * when auth open, use resource parser cache, not use reflect newInstance every time. (#4287) * [ISSUE-#4256] Just inject environment in StartingSpringApplicationRunListener (#4257) * just inject environment in StartingSpringApplicationRunListener * make nacosStartingListener is decoupling with springApplicationRunListener. * add api doc * refactor. transfer nacos listeners to SpringApplicationRunListener. * remove unuseful import * add doc info * [ISSUE #4311] Fix Derby data source related SQL LIMIT exception (#4313) * for #4311，Fixed Derby data source related SQL LIMIT exception. * fix code style. * code format. * [ISSUE-#4310] Delete the main function only for testing (#4312) * [ISSUE #4320] Fixing the Naming consistency module could not start in cluster mode (#4321) * refactor: refactor issue #4291 * fix: fixing the Naming consistency module could not start in cluster mode * fix service list can not search by groupName only (#4308) * fix service list can not search by groupName only * fix service list can not search by groupName only * fix checkStyle * add ut for NamingUtils * [ISSUE-#4258] Fix wrong path when -Dspring.config.location not set (#4259) * fix spring.config.location is nullapplication.properties when -Dspring.config.location is not set in env * fix wrong path when -Dspring.config.location not set * modify default file resource method name * fix "/" magic value * change the way of get file * not judge pathSplit by self, use Paths.get(a, b); * when spring.config.location is not set, use {nacos.home}/conf/application.properties to cover it. * refactor code * code quality enhance * just use two level to load conf. {spring.config.location}/application.properties -> classpath:/application.properties * code clean * Upgrade jraft to 1.3.5 (#4339) * 升级jraft到1.3.5以支持IPv6, 调整 NamingUtilsTest 代码格式以解决checkstyle问题 * 删除测试类的类注释 * [ISSUE-#4342] Fix nacos.core.protocol.raft.data.read_index_type isn't effect (#4343) * fix nacos.core.protocol.raft.data.read_index_type=ReadOnlyLeaseBased isn't effect and enhance log hint * define ReadOnlyOption param name just by self * [ISSUE-#4333]Add MapRowMapper to RowMapperManager (#4334) * for #4311，Fixed Derby data source related SQL LIMIT exception. * Revert "for #4311，Fixed Derby data source related SQL LIMIT exception." This reverts commit 49188f1 * fix #4333. * Remove case conversion. * [ISSUE-#4181] Normalize ContextPath value in client-side (#4326) * [ISSUE-#4181] Just use ContextPathUtil normalize ContextPath value * [ISSUE-#4181] add some test cases * fix styles at the button '新建命名空间' (#4362) * [ISSUE-#4346] Fix import code (#4347) * remove import.* * transfer first_pre to final static variable * use NamingBase.Xxx to replace constant * reuse cliClientService (#4375) * Sync code from upstream/develop Co-authored-by: 赵延 <[email protected]> Co-authored-by: liaochuntao <[email protected]> Co-authored-by: zhuhao <[email protected]> Co-authored-by: mai.jh <[email protected]> Co-authored-by: 孙继峰 <[email protected]> Co-authored-by: Mark4z <[email protected]> Co-authored-by: 邪影oO <[email protected]> Co-authored-by: Gagharv <[email protected]> Co-authored-by: iochenlei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix-#4258