Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12282]Fix the issue where monitoring data cannot be found thr… #12293

Closed
wants to merge 1 commit into from

Conversation

HMYDK
Copy link
Contributor

@HMYDK HMYDK commented Jun 26, 2024

What is the purpose of the change

#12282 Fix the issue where monitoring data cannot be found through the IP dimension in the ListeningQuery

Brief changelog

Add new query methods in the CommunicationController to support both IP and config queries. Additionally, mark @GetMapping("/configWatchers") and @GetMapping("/watcherConfigs") as @deprecated.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@HMYDK HMYDK force-pushed the develop-#12282 branch 4 times, most recently from 9eaed9f to 1b78e43 Compare June 27, 2024 00:20
…und through the IP dimension in the ListeningQuery
@Evilwa1
Copy link

Evilwa1 commented Jul 1, 2024

G

@Evilwa1
Copy link

Evilwa1 commented Jul 1, 2024

Good

@HMYDK HMYDK closed this Jul 1, 2024
@HMYDK HMYDK deleted the develop-#12282 branch July 5, 2024 05:51
@Evilwa1
Copy link

Evilwa1 commented Jul 13, 2024

Clojure CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants