[ISSUE#12074] Add Python sample for nacos #12127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CallMeHFK
changed the title
|
Sorry， the issue means add python example code in nacos console， not in nacos exmaple module。 |
|
@KomachiSion You means put it here ? |
Remove python sample
CallMeHFK
commented
May 30, 2024
Yes |
KomachiSion
approved these changes
May 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12127 +/- ##
=============================================
- Coverage 68.77% 68.70% -0.07%
Complexity 9127 9127
=============================================
Files 1252 1252
Lines 40886 40907 +21
Branches 4340 4340
=============================================
- Hits 28119 28107 -12
- Misses 10757 10787 +30
- Partials 2010 2013 +3 see 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CallMeHFK
commented
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#12074 Add Python sample for nacos
Brief changelog
The service is automatically connected to Nacos based on Python, and the service is self-registered
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like . Each commit in the pull request should have a meaningful subject line and body.[ISSUE #123] Fix UnknownException when host config not exist
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Run to make sure basic checks pass. Run to make sure unit-test pass. Run to make sure integration-test pass.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=truemvn clean install -DskipITsmvn clean test-compile failsafe:integration-test