-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE#12074] Add Python sample for nacos #12127
Conversation
Sorry, the issue means add python example code in nacos console, not in nacos exmaple module。 |
@KomachiSion You means put it here ? |
Remove python sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need nacos group developer to check this
Yes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12127 +/- ##
=============================================
- Coverage 68.77% 68.70% -0.07%
Complexity 9127 9127
=============================================
Files 1252 1252
Lines 40886 40907 +21
Branches 4340 4340
=============================================
- Hits 28119 28107 -12
- Misses 10757 10787 +30
- Partials 2010 2013 +3 see 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged, @KomachiSion should I close this issue by myself?
What is the purpose of the change
#12074 Add Python sample for nacos
Brief changelog
The service is automatically connected to Nacos based on Python, and the service is self-registered
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like . Each commit in the pull request should have a meaningful subject line and body.[ISSUE #123] Fix UnknownException when host config not exist
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Run to make sure basic checks pass. Run to make sure unit-test pass. Run to make sure integration-test pass.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=truemvn clean install -DskipITsmvn clean test-compile failsafe:integration-test