Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]Remove unnecessary judgment #11019

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

liugddx
Copy link
Contributor

@liugddx liugddx commented Aug 25, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Remove unnecessary judgment

Brief changelog

update GrpcClient

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #11019 (99a4660) into develop (a2c6e74) will increase coverage by 0.07%.
Report is 6 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11019      +/-   ##
=============================================
+ Coverage      53.29%   53.37%   +0.07%     
- Complexity      5647     5660      +13     
=============================================
  Files            932      933       +1     
  Lines          29741    29784      +43     
  Branches        3281     3291      +10     
=============================================
+ Hits           15851    15897      +46     
+ Misses         12503    12488      -15     
- Partials        1387     1399      +12     
Files Changed Coverage Δ
...ba/nacos/common/remote/client/grpc/GrpcClient.java 12.57% <0.00%> (+0.14%) ⬆️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c6e74...99a4660. Read the comment docs.

@KomachiSion KomachiSion merged commit 279e488 into alibaba:develop Sep 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants