-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fs char #10101
Fix fs char #10101
Conversation
link to #10119 |
* | ||
* @author daydreamer-ia | ||
*/ | ||
public class PathEncoderManager { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manager换成单例实现会不会比较好。
全静态方法感觉是个Utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #10101 +/- ##
=============================================
+ Coverage 50.95% 51.78% +0.82%
- Complexity 4884 5098 +214
=============================================
Files 865 875 +10
Lines 27459 27791 +332
Branches 3031 3077 +46
=============================================
+ Hits 13993 14391 +398
+ Misses 12241 12068 -173
- Partials 1225 1332 +107
... and 49 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Please do not create a Pull Request without creating an issue first.
#10067
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.