Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fs char #10101

Merged
merged 8 commits into from
Mar 27, 2023
Merged

Fix fs char #10101

merged 8 commits into from
Mar 27, 2023

Conversation

Daydreamer-ia
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.
#10067

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@Daydreamer-ia
Copy link
Contributor Author

link to #10119

*
* @author daydreamer-ia
*/
public class PathEncoderManager {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manager换成单例实现会不会比较好。

全静态方法感觉是个Utils

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov-commenter
Copy link

Codecov Report

Merging #10101 (aa0084d) into develop (81dda26) will increase coverage by 0.82%.
The diff coverage is 81.66%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10101      +/-   ##
=============================================
+ Coverage      50.95%   51.78%   +0.82%     
- Complexity      4884     5098     +214     
=============================================
  Files            865      875      +10     
  Lines          27459    27791     +332     
  Branches        3031     3077      +46     
=============================================
+ Hits           13993    14391     +398     
+ Misses         12241    12068     -173     
- Partials        1225     1332     +107     
Impacted Files Coverage Δ
...a/nacos/common/pathencoder/PathEncoderManager.java 64.00% <64.00%> (ø)
.../nacos/common/pathencoder/impl/WindowsEncoder.java 94.28% <94.28%> (ø)

... and 49 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81dda26...aa0084d. Read the comment docs.

@KomachiSion KomachiSion merged commit e002cef into alibaba:develop Mar 27, 2023
@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Mar 27, 2023
@KomachiSion KomachiSion added this to the 2.3.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants