login error but no logging

[AcrazyDog]

class in com.alibaba.nacos.client.security.SecurityProxy :

    public boolean login(List<String> servers) {

        try {
            if ((System.currentTimeMillis() - lastRefreshTime) < TimeUnit.SECONDS.toMillis(tokenTtl - tokenRefreshWindow)) {
                return true;
            }

            for (String server : servers) {
                if (login(server)) {
                    lastRefreshTime = System.currentTimeMillis();
                    return true;
                }
            }
        } catch (Throwable ignore) {
        }

        return false;
    }

when login error ,catch exception but no logging，user can't identify where is wrong quickly .

[ShawnSiao]

@i will solve it@

[haoyann]

login methed catch Exception, if it will throw Throwable, I think replace Exception here a with Throwable better.

nacos/client/src/main/java/com/alibaba/nacos/client/security/SecurityProxy.java

Line 154 in f22b93c

} catch (Exception e) {

[KomachiSion]

Welcome to enhance it like #5235 without code style problem.

[brotherlu-xcq]

I will try to solve it.

[brotherlu-xcq]

I reviewed the login code, I think we catch the Throwable is unnecessary. the main logic in login

nacos/client/src/main/java/com/alibaba/nacos/client/security/SecurityProxy.java

Line 129 in f22b93c

public boolean login(String server) {

nacos/client/src/main/java/com/alibaba/nacos/client/security/SecurityProxy.java

Line 154 in f22b93c

} catch (Exception e) {

method has catch the Exception and return false. If an error was maked, I think the follow codes after the login method shouldn't be ran. What's your opinion? @KomachiSion @haoyann

[KomachiSion]

If we remove this catch, whether will stop the schedule of scheduleWithFixedDelay?

If the async thread or schedule will be stopped. we must catch it. even we do not care it.

[brotherlu-xcq]

Yes, if there is an Exception. I think we should catch it, and keep the schedule task can re-run it. but if an Error occured, I am not sure need we stop it and make user to know the Error? usually, An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch. If we need catch the Error as well, I will change my codes to re-catch the throwable and print the error detail.

[KomachiSion]

There must be retry for login, I think. It is a protection for client.

[brotherlu-xcq]

OK, thank you. I will change this later.