-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
login error but no logging #5190
Comments
@i will solve it@ |
login methed catch
|
Welcome to enhance it like #5235 without code style problem. |
I will try to solve it. |
I reviewed the login code, I think we catch the Throwable is unnecessary. the main logic in login
|
If we remove this catch, whether will stop the schedule of scheduleWithFixedDelay? If the async thread or schedule will be stopped. we must catch it. even we do not care it. |
Yes, if there is an Exception. I think we should catch it, and keep the schedule task can re-run it. but if an Error occured, I am not sure need we stop it and make user to know the Error? usually, An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch. If we need catch the Error as well, I will change my codes to re-catch the throwable and print the error detail. |
There must be retry for login, I think. It is a protection for client. |
OK, thank you. I will change this later. |
class in com.alibaba.nacos.client.security.SecurityProxy :
when login error ,catch exception but no logging,user can't identify where is wrong quickly .
The text was updated successfully, but these errors were encountered: