Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for module nacos-config in nacos 2.0 #5092

Open
realJackSun opened this issue Mar 12, 2021 · 6 comments · Fixed by #7381 or #7430
Open

Add unit tests for module nacos-config in nacos 2.0 #5092

realJackSun opened this issue Mar 12, 2021 · 6 comments · Fixed by #7381 or #7430
Assignees
@li-xiao-shuang
Labels
area/Test
Milestone
2.5.0

Comments

@realJackSun
Copy link
Collaborator

realJackSun commented Mar 12, 2021 •
edited
Loading

This is a sub-issue of [ISSUE #4981]
The nacos-config module in nacos 2.0 coverage rate is too low, this ISSUE aims to adding more unit tests to nacos-config module.
@realJackSun realJackSun mentioned this issue Mar 12, 2021
Open
6 tasks
@KomachiSion KomachiSion added this to the 2.0.0 milestone Mar 12, 2021
@realJackSun realJackSun changed the title Add unit tests for module nacos-config Add unit tests for module nacos-config in nacos 2.0 Mar 12, 2021
@KomachiSion KomachiSion modified the milestones: 2.0.0, 2.0.1 Mar 24, 2021
@KomachiSion KomachiSion modified the milestones: 2.0.1, 2.0.2 Apr 29, 2021
@li-xiao-shuang
Copy link
Collaborator

@ i will solve it@

@KomachiSion KomachiSion modified the milestones: 2.0.2, 2.0.3 Jun 15, 2021
This was referenced Jun 28, 2021
Merged
Merged
realJackSun pushed a commit that referenced this issue Jun 28, 2021
@li-xiao-shuang
[ISSUE #5092] Add unit tests for class ExternalPermissionPersistServi…
ad3b62e 
…ceImpl in nacos 2.0 (#6184)

* add unit test for ExternalPermissionPersistServiceImpl

* add unit test for ExternalPermissionPersistServiceImpl
This was referenced Jun 29, 2021
Merged
Merged
Merged
realJackSun pushed a commit that referenced this issue Jun 29, 2021
@li-xiao-shuang
[ISSUE #5092] Add unit tests for class EmbeddedUserPersistServiceImpl…
8648642 
… in nacos 2.0 (#6194)

* add unit test for EmbeddedUserPersistServiceImpl

* add unit test for EmbeddedUserPersistServiceImpl

* add unit test for EmbeddedUserPersistServiceImpl
realJackSun pushed a commit that referenced this issue Jun 29, 2021
@li-xiao-shuang
[ISSUE #5092] Add unit tests for class EmbeddedPermissionPersistServi…
95892bc 
…ceImpl in nacos 2.0 (#6183)

* add unit test for EmbeddedPermissionPersistServiceImpl

* test() to test
ZZQ001010 pushed a commit to ZZQ001010/nacos that referenced this issue Jun 30, 2021
@li-xiao-shuang @ZZQ001010
[ISSUE alibaba#5092] Add unit tests for class ExternalPermissionPersi…
21916ab 
…stServiceImpl in nacos 2.0 (alibaba#6184)

* add unit test for ExternalPermissionPersistServiceImpl

* add unit test for ExternalPermissionPersistServiceImpl
ZZQ001010 pushed a commit to ZZQ001010/nacos that referenced this issue Jun 30, 2021
@li-xiao-shuang @ZZQ001010
[ISSUE alibaba#5092] Add unit tests for class EmbeddedUserPersistServ…
37171ea 
…iceImpl in nacos 2.0 (alibaba#6194)

* add unit test for EmbeddedUserPersistServiceImpl

* add unit test for EmbeddedUserPersistServiceImpl

* add unit test for EmbeddedUserPersistServiceImpl
ZZQ001010 pushed a commit to ZZQ001010/nacos that referenced this issue Jun 30, 2021
@li-xiao-shuang @ZZQ001010
[ISSUE alibaba#5092] Add unit tests for class EmbeddedPermissionPersi…
0571ddc 
…stServiceImpl in nacos 2.0 (alibaba#6183)

* add unit test for EmbeddedPermissionPersistServiceImpl

* test() to test
@li-xiao-shuang li-xiao-shuang mentioned this issue Jul 1, 2021
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Jul 2, 2021
@li-xiao-shuang
[ISSUE #5092] Add unit tests for class ExternalUserPersistServiceImpl…
4f0900b 
… in nacos 2.0 (#6237)

* add unit test for ExternalUserPersistServiceImpl

* add unit test for ExternalUserPersistServiceImpl
@KomachiSion KomachiSion modified the milestones: 2.0.3, 2.1.0 Jul 28, 2021
@MajorHe1
Copy link
Collaborator

@ i will solve it@ as well

MajorHe1 added a commit to MajorHe1/nacos that referenced this issue Oct 27, 2021
@MajorHe1
[ISSUE alibaba#5092] add unit tests for constant in nacos-config
b5511e5
@MajorHe1 MajorHe1 mentioned this issue Oct 27, 2021
Merged
5 tasks
This was referenced Feb 26, 2022
Merged
Merged
Merged
@Salhazry
Copy link

@ سأحلها @

KomachiSion pushed a commit that referenced this issue Mar 3, 2022
@MajorHe1
[ISSUE #5092] add test for LocalDataSourceServiceImpl (#7835)
29bb690 
* [ISSUE #5092] add test for LocalDataSourceServiceImpl

* [ISSUE #5092] delete line about LocalDataSourceServiceImpl to test cla check
KomachiSion pushed a commit that referenced this issue Mar 3, 2022
@MajorHe1
[ISSUE #5092] add unit test for ExternalDataSourceServiceImpl (#7834)
47f0c36 
* [ISSUE #5092] add unit test for ExternalDataSourceServiceImpl

* [ISSUE #5092] delete line about ExternalDataSourceServiceImplTest to make ci re-run
This was referenced Mar 3, 2022
Closed
Closed
Merged
@stale
Copy link

stale bot commented Sep 21, 2022

Thanks for your feedback and contribution. But the issue/pull request has not had recent activity more than 180 days. This issue/pull request will be closed if no further activity occurs 7 days later.
We may solve this issue in new version. So can you upgrade to newest version and retry?
If there are still issues or want to contribute again. Please create new issue or pull request again.

@stale stale bot added the expired No active for a long time label Sep 21, 2022
@KomachiSion KomachiSion removed the expired No active for a long time label Oct 10, 2022
@KomachiSion KomachiSion modified the milestones: 2.0.4, 2.2.0 Oct 10, 2022
@Salhazry
Copy link

Salhazry commented Nov 2, 2022

هذه مشكلة فرعية من [ISSUE # 4981 ] وحدة التكوين nacos في معدل تغطية nacos 2.0 منخفضة للغاية ، وتهدف هذه المشكلة إلى إضافة المزيد من اختبارات الوحدة إلى وحدة التكوين nacos.

@Salhazry
Copy link

Salhazry commented Nov 2, 2022

سوف نحلها

@KomachiSion KomachiSion modified the milestones: 2.2.0, 2.2.1 Dec 21, 2022
@KomachiSion KomachiSion modified the milestones: 2.2.1, 2.3.0 Mar 9, 2023
@KomachiSion KomachiSion modified the milestones: 2.3.0, 2.3.1 Dec 5, 2023
@KomachiSion KomachiSion modified the milestones: 2.3.1, 2.4.0 Feb 27, 2024
@KomachiSion KomachiSion modified the milestones: 2.4.0, 2.4.1 Jul 24, 2024
@KomachiSion KomachiSion modified the milestones: 2.4.1, 2.4.2 Aug 19, 2024
@KomachiSion KomachiSion modified the milestones: 2.4.2, 2.5.0 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@li-xiao-shuang li-xiao-shuang

Labels
area/Test
Projects
None yet
Milestone
2.5.0
5 participants
@li-xiao-shuang @KomachiSion @MajorHe1 @realJackSun @Salhazry