We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
NamingSubscriberServiceLocalImpl:
NamingSubscriberServiceLocalImpl
@Override public Collection<Subscriber> getSubscribers(String namespaceId, String serviceName) { Collection<Subscriber> result = new HashSet<>(); result.addAll(namingSubscriberServiceV1.getSubscribers(namespaceId, serviceName)); result.addAll(namingSubscriberServiceV2.getSubscribers(namespaceId, serviceName)); return result; }
NamingSubscriberServiceV1Impl:
NamingSubscriberServiceV1Impl
@Override public Collection<Subscriber> getSubscribers(String namespaceId, String serviceName) { String serviceKey = UtilsAndCommons.assembleFullServiceName(namespaceId, serviceName); ConcurrentMap<String, PushClient> clientConcurrentMap = clientMap.get(serviceKey); if (Objects.isNull(clientConcurrentMap)) { return null; // <--- } ... }
Expected behavior
returns an empty list
Acutally behavior
return null
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered:
Fix alibaba#5001. Returns empty list when service has no subscribers.
878d48e
6995193
Fix #5001. Returns empty list when service has no subscribers. (#5004)
cab401d
pixystone
No branches or pull requests
Describe the bug
NamingSubscriberServiceLocalImpl
:NamingSubscriberServiceV1Impl
:Expected behavior
returns an empty list
Acutally behavior
return null
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: