Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] The instances still exist after client didn't sent heart beat. #4829

Closed
horizonzy opened this issue Jan 28, 2021 · 8 comments · Fixed by #5131
Closed

[Bug] The instances still exist after client didn't sent heart beat. #4829

horizonzy opened this issue Jan 28, 2021 · 8 comments · Fixed by #5131
Assignees
@horizonzy
Labels
kind/bug Category issues or prs related to bug.

Comments

@horizonzy
Copy link
Collaborator

Describe the bug
nacos-server env: three nacos-server nodes build cluster.
node 1: 10.248.224.223
node 2: 10.248.224.187
node 3: 10.248.224.198

  1. start node1.
  2. register 400 service which hold 100 instances to server.
  3. start another two nacos-server nodes (node2, node3)
  4. wait for a while
  5. stop nacos-client
  6. 10 service of 400 still exist 100 instances.

Desktop (please complete the following information):

  • OS: centos 7
  • Version [e.g. nacos-server 1.4.2-SNAPSHOT, nacos-client 1.4.1]
  • Module [e.g. naming]

image
image
image
@horizonzy horizonzy self-assigned this Jan 28, 2021
@horizonzy

This comment has been minimized.

Sign in to view
@horizonzy horizonzy changed the title [Bug] The instances still exist when the client not sent heart beat. [Bug] The instances still exist after client didn't sent heart beat. Jan 28, 2021
@horizonzy

This comment has been minimized.

Sign in to view
@horizonzy

This comment has been minimized.

Sign in to view
@KomachiSion
Copy link
Collaborator

So should we removed oldService from listener map first, and then to destroy old service?

@horizonzy
Copy link
Collaborator Author

So should we removed oldService from listener map first, and then to destroy old service?

The code should be optimize. But I am not sure this solution can solve this strange case.

@horizonzy

This comment has been minimized.

Sign in to view
@horizonzy
Copy link
Collaborator Author

refer #4821

@horizonzy
Copy link
Collaborator Author

horizonzy commented Mar 7, 2021 •
edited
Loading

the reason see: https://www.yuque.com/docs/share/1735ed96-49e8-46e5-bda7-ed7188333042?# 《Nacos客户端停止后，服务无法正常下线问题》

@horizonzy horizonzy added kind/bug Category issues or prs related to bug. and removed kind/research labels Mar 8, 2021
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Mar 17, 2021
@KomachiSion
Fix alibaba#4829, remove instance when distro and raft remove instanc…
d30d23e 
…es data.
@KomachiSion KomachiSion mentioned this issue Mar 17, 2021
Merged
5 tasks
horizonzy pushed a commit that referenced this issue Mar 18, 2021
@KomachiSion
[ISSUE#4829] Remove instance when distro and raft remove instances da…
0003267 
…ta. (#5131)

* Fix #4829, remove instance when distro and raft remove instances data.

* Remove synchronized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@horizonzy horizonzy

Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE#4829] Remove instance when distro and raft remove instances data. KomachiSion/nacos
2 participants
@horizonzy @KomachiSion