Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding Guidelines #38

Closed
jasonsuzhou opened this issue Aug 31, 2018 · 1 comment
Closed

Coding Guidelines #38

jasonsuzhou opened this issue Aug 31, 2018 · 1 comment
Assignees

Comments

@jasonsuzhou
Copy link

According to 《Alibaba Java Coding Guidelines》, the interface should not have the public modifier.
e.g.
com.alibaba.nacos.api.config.ConfigService.java

public interface ConfigService {

	public String getConfig(String dataId, String group, long timeoutMs) throws NacosException;

	public void addListener(String dataId, String group, Listener listener) throws NacosException;

	public boolean publishConfig(String dataId, String group, String content) throws NacosException;

	public boolean removeConfig(String dataId, String group) throws NacosException;

	public void removeListener(String dataId, String group, Listener listener);

}
@yanlinly yanlinly self-assigned this Oct 30, 2018
@yanlinly
Copy link
Collaborator

I fix it in 0.4.0, thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants