feat: rsc server route #6528
Merged
feat: rsc server route #6528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClarkXia
reviewed
Sep 12, 2023
examples/with-rsc/package.json
Outdated
| @@ -12,7 +12,8 @@ | |||
| "@ice/app": "workspace:*", | |||
| "@ice/runtime": "workspace:*", | |||
| "react": "^18.2.0", | |||
| "react-dom": "^18.2.0" | |||
| "react-dom": "^18.2.0", | |||
| "react-router-dom": "6.14.2" | |||
| location, | ||
| renderOptions, | ||
| }: RenderServerEntry, | ||
| ): Promise<Response> { | ||
| const { Document } = renderOptions; | ||
| const appContext = runtime.getAppContext(); | ||
| const { routes, routePath, loaderData, basename } = appContext; | ||
| const { routes, matches, routeModules, requestContext, ...staticContext } = appContext; |
| @@ -289,6 +288,11 @@ async function doRender(serverContext: ServerContext, renderOptions: RenderOptio | |||
| } | |||
| } | |||
|
|
|||
| // Render Document for RSC App. | |||
There was a problem hiding this comment.
RSC 相关逻辑可以统一考虑在 runRSCApp 下处理，公共的 server 逻辑后面可以单独抽象
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat-rsc #6528 +/- ##
============================================
- Coverage 80.01% 79.95% -0.07%
============================================
Files 254 255 +1
Lines 22200 22157 -43
Branches 2729 2727 -2
============================================
- Hits 17764 17715 -49
- Misses 4392 4398 +6
Partials 44 44
☔ View full report in Codecov by Sentry. |
ClarkXia
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: