Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(sourcemap): add "sourcesContent" to the output source map #2399

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

zengguirong
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Set the inlineSources option to true in tsconfig.json.

This is because in the current source map file, I found the sources field that is pointing to the source location (such as "sources":["../src/index.ts"] in https://cdn.jsdelivr.net/npm/@formily/[email protected]/esm/index.js.map). But the src folder is not inclued in the published package.
When using some esm bundlers such as Vite, the dev server could not find the source file and finally response error with code 404, which means that I can not debug the formily source in browser with source map enabled when using Vite.

@CLAassistant
Copy link

CLAassistant commented Nov 5, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #2399 (116b265) into formily_next (6544abb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #2399   +/-   ##
=============================================
  Coverage         95.34%   95.34%           
=============================================
  Files               140      140           
  Lines              6129     6129           
  Branches           1536     1536           
=============================================
  Hits               5844     5844           
  Misses              280      280           
  Partials              5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6544abb...116b265. Read the comment docs.

@janryWang
Copy link
Collaborator

麻烦签一下CLA

@janryWang janryWang merged commit 3305cf8 into alibaba:formily_next Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants