Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react): silent useForm for child form sence #2302

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #2302 (8a7244a) into formily_next (c48212c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #2302   +/-   ##
=============================================
  Coverage         95.29%   95.30%           
=============================================
  Files               138      139    +1     
  Lines              6099     6108    +9     
  Branches           1538     1540    +2     
=============================================
+ Hits               5812     5821    +9     
  Misses              282      282           
  Partials              5        5           
Impacted Files Coverage Δ
packages/react/src/hooks/useForm.ts 100.00% <100.00%> (ø)
packages/react/src/hooks/index.ts 100.00% <0.00%> (ø)
packages/core/src/shared/checkers.ts 100.00% <0.00%> (ø)
packages/react/src/hooks/useParentForm.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c48212c...8a7244a. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: -81 B (0%)

Total Size: 438 kB

Filename Size Change
packages/react/dist/formily.react.umd.development.js 11.3 kB -41 B (0%)
packages/react/dist/formily.react.umd.production.js 7.02 kB -40 B (-1%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 61.6 kB
packages/antd/dist/formily.antd.umd.production.js 35 kB
packages/core/dist/formily.core.umd.development.js 18.9 kB
packages/core/dist/formily.core.umd.production.js 12.9 kB
packages/element/dist/formily.element.umd.development.js 55 kB
packages/element/dist/formily.element.umd.production.js 31.4 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.86 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.33 kB
packages/next/dist/formily.next.umd.development.js 63.1 kB
packages/next/dist/formily.next.umd.production.js 36.8 kB
packages/path/dist/formily.path.umd.development.js 11 kB
packages/path/dist/formily.path.umd.production.js 7.65 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.26 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.83 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.8 kB
packages/reactive/dist/formily.reactive.umd.development.js 8.88 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.13 kB
packages/shared/dist/formily.shared.umd.development.js 7.38 kB
packages/shared/dist/formily.shared.umd.production.js 4.19 kB
packages/validator/dist/formily.validator.umd.development.js 8.31 kB
packages/validator/dist/formily.validator.umd.production.js 6.18 kB
packages/vue/dist/formily.vue.umd.development.js 15.2 kB
packages/vue/dist/formily.vue.umd.production.js 9.39 kB

compressed-size-action

@janryWang janryWang merged commit c2c2e30 into formily_next Oct 14, 2021
@janryWang janryWang deleted the silent_to_useForm branch October 14, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant