Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactive): fix tracker recursive react #1709

Merged
merged 10 commits into from
Jul 3, 2021

Conversation

janryWang
Copy link
Collaborator

@janryWang janryWang commented Jul 3, 2021

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #1672 #1705

因为这两个Bug有互斥关系,最后发现是reaction api不支持嵌套执行,其实是需要支持的,因为它有脏检查做安全守护

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2021

Size Change: +7 B (0%)

Total Size: 575 kB

Filename Size Change
packages/json-schema/dist/formily.json-schema.umd.development.js 6.86 kB -2 B (0%)
packages/react/dist/formily.react.umd.development.js 11.2 kB -2 B (0%)
packages/reactive/dist/formily.reactive.umd.production.js 4.54 kB +13 B (0%)
packages/vue/dist/formily.vue.umd.development.js 14.3 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
designable/antd/dist/formily.designable.antd.umd.development.js 133 kB
designable/antd/dist/formily.designable.antd.umd.production.js 103 kB
designable/next/dist/formily.designable.next.umd.development.js 332 B
designable/next/dist/formily.designable.next.umd.production.js 252 B
designable/setters/dist/formily.designable.antd.umd.development.js 331 B
designable/setters/dist/formily.designable.antd.umd.production.js 251 B
packages/antd/dist/formily.antd.umd.development.js 59.3 kB
packages/antd/dist/formily.antd.umd.production.js 34.1 kB
packages/core/dist/formily.core.umd.development.js 17.8 kB
packages/core/dist/formily.core.umd.production.js 12 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.87 kB
packages/next/dist/formily.next.umd.development.js 60.4 kB
packages/next/dist/formily.next.umd.production.js 35.4 kB
packages/path/dist/formily.path.umd.development.js 12 kB
packages/path/dist/formily.path.umd.production.js 8.38 kB
packages/react/dist/formily.react.umd.production.js 6.97 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.38 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.23 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.37 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.76 kB
packages/reactive/dist/formily.reactive.umd.development.js 7.63 kB
packages/shared/dist/formily.shared.umd.development.js 6.35 kB
packages/shared/dist/formily.shared.umd.production.js 4.1 kB
packages/validator/dist/formily.validator.umd.development.js 7.01 kB
packages/validator/dist/formily.validator.umd.production.js 5.61 kB
packages/vue/dist/formily.vue.umd.production.js 9.18 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #1709 (2191624) into formily_next (e6fd58e) will increase coverage by 1.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #1709      +/-   ##
================================================
+ Coverage         90.24%   91.75%   +1.51%     
================================================
  Files               136      135       -1     
  Lines              6211     5983     -228     
  Branches           1586     1489      -97     
================================================
- Hits               5605     5490     -115     
+ Misses              602      489     -113     
  Partials              4        4              
Impacted Files Coverage Δ
packages/reactive/src/types.ts 100.00% <ø> (ø)
packages/reactive/src/annotations/computed.ts 91.04% <100.00%> (+2.47%) ⬆️
packages/reactive/src/autorun.ts 100.00% <100.00%> (+2.38%) ⬆️
packages/reactive/src/reaction.ts 99.17% <100.00%> (-0.04%) ⬇️
packages/reactive/src/tracker.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6fd58e...2191624. Read the comment docs.

@janryWang janryWang merged commit 3de82d5 into formily_next Jul 3, 2021
@janryWang janryWang deleted the fix_tracker_recursive branch July 3, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Field reactions 内部设置 display=none,不会触发 visible reaction 的删值操作
1 participant