Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying modification pattern in PR#3693 to SQLASTOutputVisitor#visit #3956

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Applying modification pattern in PR#3693 to SQLASTOutputVisitor#visit #3956

merged 2 commits into from
Nov 3, 2020

Conversation

T45K
Copy link
Contributor

@T45K T45K commented Sep 21, 2020

In #3693, MySqlOutputVisitor#visit was modified, but its similar method, SQLASTOutputVisitor#visit was not modified.
I changed it for consistency.

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wenshao
Copy link
Member

wenshao commented Oct 23, 2020

1.2.1代码做了较大的重构，请处理冲突

@T45K
Copy link
Contributor Author

T45K commented Oct 23, 2020 •
edited
Loading

I've done it.

@wenshao wenshao merged commit 3a30cff into alibaba:master Nov 3, 2020
@wenshao wenshao added this to the 1.2.2 milestone Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@T45K @CLAassistant @wenshao