Use dense Adam by convert indexedslices to tensor in DIEN #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new implementation converts indexedslices to tensor in Adam optimizer.
Tensorflow use a single op "apply_adam" to deal with tensors, while use many small ops to deal wth indexedslices in sparse Adam implementation.
To use tensors avoids to load these small ops repeatedly and saves time.
In my experiment, this change improves about 12% throughput with batch size 128 on Intel Xeon 8260 processors.