Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dense Adam by convert indexedslices to tensor in DIEN #70

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

retonym
Copy link
Contributor

@retonym retonym commented Jul 7, 2020

The new implementation converts indexedslices to tensor in Adam optimizer.
Tensorflow use a single op "apply_adam" to deal with tensors, while use many small ops to deal wth indexedslices in sparse Adam implementation.
To use tensors avoids to load these small ops repeatedly and saves time.
In my experiment, this change improves about 12% throughput with batch size 128 on Intel Xeon 8260 processors.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@retonym retonym changed the title Use dense Adam by convert indexedslices to tensor Use dense Adam by convert indexedslices to tensor in DIEN Jul 7, 2020
@Zantares
Copy link

@retonym your CLA is not signed, please check the reply of @CLAassistant to continue the process.

@retonym
Copy link
Contributor Author

retonym commented Jul 27, 2020

I have move the changes of this PR to DIEN_TF2 folder. It will not influence the code in the original DIEN folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants