feature: add metric exporter interface #3416
Conversation
LearningGp
added
to-review
| try { | ||
| instance = SpiLoader.of(MetricExporter.class).loadFirstInstance(); | ||
| } catch (Throwable t) { | ||
| // ignore |
There was a problem hiding this comment.
It would be better to log the exception using RecordLog.
| try { | ||
| metricWriter.write(entry.getKey(), entry.getValue()); | ||
| } catch (Exception e) { | ||
| RecordLog.warn("[MetricTimerListener] Write metric error", e); |
There was a problem hiding this comment.
MetricTimerListener -> DefaultExporter
| static { | ||
| MetricExporter instance = null; | ||
| try { | ||
| instance = SpiLoader.of(MetricExporter.class).loadFirstInstance(); |
There was a problem hiding this comment.
We may need to discuss whether it's more suitable to get the first implementation or to obtain a list to support multiple exporters.
|
We may need to discuss whether we should support having multiple exporters active at the same time. I'm not sure about your perspective on this. |
I keep one leave is order to sync the old logic, to be honest, i agree with you that support multiple exporters here. Do i keep more exporters active this pr? |
Describe what this PR does / why we need it
#3314
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews