Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics name for monitor better select in JMX MetricBeanWriter #2976

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Update metrics name for monitor better select in JMX MetricBeanWriter #2976

merged 5 commits into from
Nov 30, 2022

Conversation

garroshh
Copy link
Contributor

@garroshh garroshh commented Nov 28, 2022 •
edited
Loading

Describe what this PR does / why we need it

  1. metrics name in general is inmutable, but now we have a varible (appName) in metrics name.
  2. we can put appName varible in metrics label not metrics name for prometheus better select.

Describe how you did it

update the metrics name, result like the follow pic:

Describe how to verify it

企业微信截图_3d7a0eaf-c394-4d34-afa5-80f849ea27e8

企业微信截图_7d2ff92d-f873-4eb7-aed6-8e9a69bc0357

image

@sczyh30 sczyh30 added area/metrics Issues or PRs related to metrics and monitoring kind/enhancement Category issues or prs related to enhancement. labels Nov 28, 2022
@sczyh30 sczyh30 changed the title update metrics name for monitor better select Update metrics name for monitor better select in JMX MetricBeanWriter Nov 29, 2022
sczyh30
sczyh30 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 8a00a86 into alibaba:master Nov 30, 2022
@sczyh30
Copy link
Member

sczyh30 commented Nov 30, 2022

Nice work. Thanks for contributing!

@sczyh30 sczyh30 added this to the v2.0.0 milestone Nov 30, 2022
@wilsonwu wilsonwu mentioned this pull request Apr 14, 2023
Closed
LearningGp pushed a commit that referenced this pull request Dec 28, 2023
@garroshh @LearningGp
Update metrics name for better monitor selection in JMX MetricBeanWri…
1483669 
…ter extension (#2976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczyh30 sczyh30 sczyh30 approved these changes

@brotherlu-xcq brotherlu-xcq Awaiting requested review from brotherlu-xcq

Assignees
No one assigned
Labels
area/metrics Issues or PRs related to metrics and monitoring kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@garroshh @sczyh30