新增 csp.sentinel.log.level 启动配置项，可设置为OFF，进行关闭日志 #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
第一次贡献源代码，这个pr是有问题合并不了？还是需要审批流程？ |
brotherlu-xcq
requested changes
Jan 4, 2022
| @@ -80,7 +82,9 @@ private static void startMetricTimerListener() { | |||
| SentinelConfig.METRIC_FLUSH_INTERVAL); | |||
| return; | |||
| } | |||
| SCHEDULER.scheduleAtFixedRate(new MetricTimerListener(), 0, flushInterval, TimeUnit.SECONDS); | |||
| if (!LogBase.getLogLevel().equals(Level.OFF)) { | |||
There was a problem hiding this comment.
metric的写日志逻辑实际已经通过csp.sentinel.metric.flush.interval参数进行控制了，这个日志打印我觉得更应该在日志层面调用去控制，而不是通过日志级别来控制metricTimerListener的启用。
sczyh30
reviewed
Jan 10, 2022
| @@ -32,6 +32,7 @@ | |||
| import java.util.concurrent.Executors; | |||
| import java.util.concurrent.ScheduledExecutorService; | |||
| import java.util.concurrent.TimeUnit; | |||
| import java.util.logging.Level; | |||
There was a problem hiding this comment.
Could you please remove the unused import?
| // load log level | ||
| String logLevelString = properties.getProperty(LOG_LEVEL); | ||
| if (logLevelString != null && (logLevelString = logLevelString.trim()).length() > 0) { | ||
| logLevel = Level.parse(logLevelString); |
There was a problem hiding this comment.
What if the logLevel is invalid?
|
Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=2514 |
|
cc @brotherlu-xcq Any other suggestions? |
I have no more suggestions. LGTM |
|
Thanks for contributing! |
Zhang-0952
pushed a commit
to Zhang-0952/Sentinel
that referenced
this pull request
Mar 4, 2022
* Add `csp.sentinel.log.level` property to support logging level for record logs (not for block log and metric log)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
对应issues：Add record log level configuration support | 支持配置 record 日志的输出级别配置 #2505
通过添加启动配置项 csp.sentinel.log.level=OFF，可以选择性的关闭产生的日志