Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard try to access Alipay domain #522

Closed
MickMo opened this issue Feb 26, 2019 · 4 comments
Closed

Dashboard try to access Alipay domain #522

MickMo opened this issue Feb 26, 2019 · 4 comments
Labels
area/dashboard Issues or PRs about Sentinel Dashboard good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.

Comments

@MickMo
Copy link
Contributor

MickMo commented Feb 26, 2019 •
edited
Loading

when I try to modify Sentinel-Dashboard,I notice that it send a request to https://kcart.alipay.com/web/bi.do?BIProfile=merge&d=%5B%7B%22pg%22%3A%22http%3A%2F%2Flocalhost%3A8080%2F%23%2Fdashboard%2Fhome%22%2C%22r%22%3A1551171313469%2C%22g2%22%3Atrue%2C%22version%22%3A%223.3.2%22%2C%22page_type%22%3A%22syslog%22%7D%5D
What is this?

image
@sczyh30 sczyh30 added kind/question Category issues related to questions or problems area/dashboard Issues or PRs about Sentinel Dashboard labels Feb 26, 2019
@sczyh30
Copy link
Member

sczyh30 commented Feb 26, 2019

Hi, it's the G2 library that sends the request. We've tried to disable this using G2.track(false) in metrics.js but it did not actually take effect. Would you like to contribute a PR to fix it?

@sczyh30 sczyh30 added the good first issue Good for newcomers label Feb 26, 2019
@MickMo
Copy link
Contributor Author

MickMo commented Feb 28, 2019

According to the newest announcement on
https://github.com/antvis/g2/blob/master/README.zh-CN.md.
By upgrade G2 Lib to version @antv/[email protected] we can solve this problem

@MickMo
Copy link
Contributor Author

MickMo commented Feb 28, 2019

Update by updating G2 lib to 3.4.10,problem solved.
image

I will make a PR later.

MickMo added a commit to MickMo/Sentinel that referenced this issue Feb 28, 2019
@MickMo
Fixed Dashboard try to access Alipay domain https://kcart.alipay.com…
ade417f 
…/web/bi.do?`

By upgrading G2 Lib to version 3.4.10

alibaba#522
@MickMo MickMo mentioned this issue Feb 28, 2019
Merged
@sczyh30
Copy link
Member

sczyh30 commented Feb 28, 2019

Update by updating G2 lib to 3.4.10,problem solved.
image

I will make a PR later.

👍

@sczyh30 sczyh30 added kind/enhancement Category issues or prs related to enhancement. and removed kind/question Category issues related to questions or problems labels Feb 28, 2019
MickMo added a commit to MickMo/Sentinel that referenced this issue Mar 1, 2019
@MickMo
Fixed Dashboard try to access Alipay domain https://kcart.alipay.com…
b18cdea 
…/web/bi.do?`

By upgrading G2 Lib to version 3.4.10

alibaba#522
MickMo added a commit to MickMo/Sentinel that referenced this issue Mar 20, 2019
@MickMo
Fixed Dashboard try to access Alipay domain https://kcart.alipay.com…
83087fc 
…/web/bi.do?`

By upgrading G2 Lib to version 3.4.10

alibaba#522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dashboard Issues or PRs about Sentinel Dashboard good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sczyh30 @MickMo