解决trafficRouter重复监听的问题

alibaba · Feb 6, 2023 · a265fad · a265fad
1 parent ae09653
commit a265fad
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/.../src/main/java/com/alibaba/csp/sentinel/traffic/rule/router/TrafficRouterRuleManager.java b/.../src/main/java/com/alibaba/csp/sentinel/traffic/rule/router/TrafficRouterRuleManager.java
@@ -42,18 +42,18 @@ public static TrafficRoutingRuleGroup getTrafficRoutingRules() {
 	}
 
 	public static synchronized void register(String app) {
-		trafficRouterRuleListenerMap.put(app, object);
-
-		for (RemoteAppObserver subscriber : subscribers) {
-			subscriber.onRemoteAppAppears(app);
+		Object value = trafficRouterRuleListenerMap.put(app, object);
+		if (value == null) {
+			for (RemoteAppObserver subscriber : subscribers) {
+				subscriber.onRemoteAppAppears(app);
+			}
 		}
 	}
 
 	public static synchronized void unregister(String app) {
-		trafficRouterRuleListenerMap.remove(app);
-		// todo unsubscribe
 		for (RemoteAppObserver subscriber : subscribers) {
 			subscriber.onRemoteAppDisappears(app);
 		}
+		trafficRouterRuleListenerMap.remove(app);
 	}
 }