Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add several Byzantine robust algorithms #552

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

private-mechanism
Copy link
Contributor

add several Byzantine robust algorithms and modify some auxiliary files

@private-mechanism private-mechanism marked this pull request as ready for review March 27, 2023 03:55
xieyxclack
xieyxclack previously approved these changes Mar 27, 2023
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieyxclack xieyxclack added the Feature New feature label Mar 27, 2023
@xieyxclack
Copy link
Collaborator

This pr is modified from #542

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add cfg.data.root='test_data/' in the unittests

Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The BFT aggregators are important and useful in FL, thanks a lot for your contribution! @private-mechanism

@xieyxclack xieyxclack merged commit 2f31956 into alibaba:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants