New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There may be a bug in the function of "__track_and_check_best" of "core/monitors/early_stopper.py" file #373

Closed

zza234s opened this issue Sep 12, 2022 · 1 comment · Fixed by #374

Labels

bug

zza234s commented Sep 12, 2022

The result of executing the code in the red box is add(eval_score, delta) <new_result, instead of the expected add(eval_score, delta) >new_result

Because of the assignment statement on line 46

rayrayraykk linked a pull request

that will close this issue

Fix early_stop when the metric is the larger the better #374

Merged

yxdyc closed this as completed in #374

Collaborator

rayrayraykk commented Sep 13, 2022

Hello, thanks for pointing out this bug, we've fixed it in #374.

rayrayraykk added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment