Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix early_stop when the metric is the larger the better #374

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Fix early_stop when the metric is the larger the better #374

merged 3 commits into from
Sep 13, 2022

Conversation

rayrayraykk
Copy link
Collaborator

As the title says.

@rayrayraykk rayrayraykk added the bug Something isn't working label Sep 13, 2022
@rayrayraykk rayrayraykk linked an issue Sep 13, 2022 that may be closed by this pull request
There may be a bug in the function of "__track_and_check_best" of "core/monitors/early_stopper.py" file #373
Closed
yxdyc
yxdyc reviewed Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can modify the comment line 65 accordingly, for easy code reading

@yxdyc yxdyc merged commit e64919c into alibaba:master Sep 13, 2022
@rayrayraykk rayrayraykk mentioned this pull request Sep 13, 2022
Closed
@rayrayraykk rayrayraykk deleted the fix_stop_best branch September 13, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxdyc yxdyc yxdyc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There may be a bug in the function of "__track_and_check_best" of "core/monitors/early_stopper.py" file
2 participants
@rayrayraykk @yxdyc