Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Menu): child-selected should work in popup mode #999

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

youluna
Copy link
Member

@youluna youluna commented Aug 12, 2019

No description provided.

src/menu/view/menu.jsx Show resolved Hide resolved
src/menu/view/sub-menu.jsx Show resolved Hide resolved
@youluna youluna requested a review from myronliu347 August 12, 2019 13:09
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #999 into master will decrease coverage by 0.01%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   91.44%   91.43%   -0.02%     
==========================================
  Files         247      247              
  Lines       14406    14415       +9     
  Branches     4558     4563       +5     
==========================================
+ Hits        13174    13180       +6     
- Misses       1213     1216       +3     
  Partials       19       19
Impacted Files Coverage Δ
src/menu/view/popup-item.jsx 92.79% <100%> (+0.48%) ⬆️
src/menu/view/sub-menu.jsx 93.54% <100%> (ø) ⬆️
src/menu/view/menu.jsx 89.15% <50%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1a0ff...44b1266. Read the comment docs.

@myronliu347
Copy link
Member

单测不通过看下

@youluna youluna force-pushed the fix-iconOnly-highlight branch from de3bf82 to 44b1266 Compare August 13, 2019 05:17
@youluna youluna merged commit cf66a80 into alibaba-fusion:master Aug 13, 2019
@youluna youluna deleted the fix-iconOnly-highlight branch September 29, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants