Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tree): Still can check after disableChecked #925

Merged
merged 5 commits into from
Aug 5, 2019

Conversation

myronliu347
Copy link
Member

fixed #872

@myronliu347 myronliu347 requested a review from youluna July 26, 2019 03:38
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #925 into master will decrease coverage by 0.02%.
The diff coverage is 95.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #925      +/-   ##
=========================================
- Coverage   91.43%   91.4%   -0.03%     
=========================================
  Files         245     245              
  Lines       14167   14221      +54     
  Branches     4449    4487      +38     
=========================================
+ Hits        12953   12999      +46     
- Misses       1195    1203       +8     
  Partials       19      19
Impacted Files Coverage Δ
src/tree-select/tree-select.jsx 93.44% <100%> (ø) ⬆️
src/tree/view/util.js 94.17% <94.82%> (-4.63%) ⬇️
src/tree/view/tree.jsx 90.8% <96.96%> (ø) ⬆️
src/cascader-select/cascader-select.jsx 89.04% <0%> (-0.27%) ⬇️
src/upload/dragger.jsx 100% <0%> (ø) ⬆️
src/upload/upload.jsx 82.23% <0%> (+0.11%) ⬆️
src/field/index.js 93.94% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b193dad...210d84e. Read the comment docs.

@youluna
Copy link
Member

youluna commented Jul 29, 2019

除了 #872 之外好像还有父节点控制了disabled的子节点等的问题,把解决的问题都写清楚吧,后续好跟踪

另外改动比较大,建议放到Y位

src/tree/view/util.js Outdated Show resolved Hide resolved
src/tree/view/util.js Show resolved Hide resolved
src/tree/view/util.js Show resolved Hide resolved
@youluna
Copy link
Member

youluna commented Aug 1, 2019

还差 childChecked 函数的抽离,另外这个放到1.17.0是不是更合适

@youluna youluna changed the base branch from master to feat/1.17.0 August 5, 2019 13:58
@youluna youluna merged commit 39db197 into alibaba-fusion:feat/1.17.0 Aug 5, 2019
@myronliu347 myronliu347 deleted the fix-tree branch October 11, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants