fix(Typescript): add a tags ts. #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## typescript-opt #922 +/- ##
===============================================
Coverage 91.43% 91.43%
===============================================
Files 245 245
Lines 14167 14167
Branches 4449 4449
===============================================
Hits 12953 12953
Misses 1195 1195
Partials 19 19Continue to review full report at Codecov.
|
|
confusing commit message, maybe "fix(Typescript): add href & target for Button" is better. 注释也要优化下，这两个属性是Button的components为a的时候才有意义的 |
nianxiongdi
force-pushed
the
typescript-opt
branch
from
e1d3bf5 to
eff5062
Compare
nianxiongdi
force-pushed
the
typescript-opt
branch
from
eff5062 to
443eecf
Compare
youluna
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.