Docs/a11y #487
Merged
Docs/a11y #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## docs/a11y #487 +/- ##
==========================================
Coverage 91.08% 91.08%
==========================================
Files 242 242
Lines 13608 13608
Branches 4212 4212
==========================================
Hits 12395 12395
Misses 1194 1194
Partials 19 19Continue to review full report at Codecov.
|
youluna
reviewed
Mar 22, 2019
site/zh-cn/a11y/part1/WAI-ARIA.md
Outdated
|
|
||
| 比如对于`role=region`，我们必须添加以下`Required`的`aria-*`： | ||
| - `aria-labelledby` | ||
| - `aria-label` |
There was a problem hiding this comment.
Required 和 Optional这段有参考资料吗？感觉跟我理解的有些出入，我记得没有“强制要求”这么一类
并且 aria-labelledby 跟 aria-label 只能出现一个。
youluna
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.