Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Select): Selecting all does not affect options that are already disabled 4802 #4848

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(Select): Selecting all does not affect options that are already disabled 4802 #4848

merged 1 commit into from
Jul 19, 2024

Conversation

YunMeng99
Copy link
Contributor

@YunMeng99 YunMeng99 commented May 15, 2024 •
edited
Loading

fix(Select): disabled does not affect all selections close #4802

@YunMeng99 YunMeng99 requested a review from kyokaxin May 15, 2024 10:12
@YunMeng99 YunMeng99 linked an issue May 15, 2024 that may be closed by this pull request
[Select]Select 禁用选项的默认选中与全选冲突 #4802
Closed
@YunMeng99 YunMeng99 changed the title fix(Select): fix(Select): disabled does not affect all selections close 4848 May 15, 2024
@YunMeng99 YunMeng99 changed the title fix(Select): disabled does not affect all selections close 4848 fix(Select): disabled does not affect all selections close 4802 May 15, 2024
@eternalsky
Copy link
Contributor

check 有报错，可以再 rebase 一下 master

@github-actions GitHub Actions
Copy link

你好，该 pr 已 30 天没有活动，因此被标记为 stale，如果之后的 7 天仍然没有活动，该 pr 将被自动关闭

@github-actions github-actions bot added the Stale not active for a lone time label Jun 19, 2024
@eternalsky eternalsky removed the Stale not active for a lone time label Jun 20, 2024
@eternalsky
Copy link
Contributor

这个目前和主干冲突了，请 rebase 之后重新提交一下

@YunMeng99 YunMeng99 force-pushed the fix/Select-selectAll branch 2 times, most recently from 5563cfc to 8c06e48 Compare July 1, 2024 07:55
@YunMeng99 YunMeng99 changed the title fix(Select): disabled does not affect all selections close 4802 fix(Select): Selecting all does not affect options that are already disabled 4802 Jul 1, 2024
eternalsky
eternalsky requested changes Jul 1, 2024
View reviewed changes
components/select/data-store.ts Outdated Show resolved Hide resolved
components/select/select.tsx Outdated Show resolved Hide resolved
components/select/select.tsx Outdated Show resolved Hide resolved
eternalsky
eternalsky requested changes Jul 3, 2024
View reviewed changes
components/select/select.tsx Outdated Show resolved Hide resolved
components/select/select.tsx Outdated Show resolved Hide resolved
components/select/select.tsx Outdated Show resolved Hide resolved
@YunMeng99 YunMeng99 requested review from eternalsky and removed request for kyokaxin July 4, 2024 06:10
eternalsky
eternalsky requested changes Jul 15, 2024
View reviewed changes
components/select/select.tsx Outdated Show resolved Hide resolved
components/select/select.tsx Outdated Show resolved Hide resolved
components/select/select.tsx Outdated Show resolved Hide resolved
@eternalsky eternalsky merged commit 7ddc302 into master Jul 19, 2024
3 of 4 checks passed
@eternalsky eternalsky deleted the fix/Select-selectAll branch July 19, 2024 01:53
@eternalsky eternalsky restored the fix/Select-selectAll branch July 19, 2024 04:02
@eternalsky eternalsky mentioned this pull request Jul 19, 2024
Merged
@eternalsky eternalsky deleted the fix/Select-selectAll branch July 19, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternalsky eternalsky eternalsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select]Select 禁用选项的默认选中与全选冲突
2 participants
@YunMeng99 @eternalsky