feat(dialog): support custom padding bottom when no footer #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3800 +/- ##
==========================================
- Coverage 90.59% 90.57% -0.03%
==========================================
Files 303 303
Lines 17819 17833 +14
Branches 5369 5375 +6
==========================================
+ Hits 16143 16152 +9
- Misses 1657 1661 +4
- Partials 19 20 +1
Continue to review full report at Codecov.
|
|
感觉会有breakchange， 如果用户就是期望不写footer 的时候内容是向下贴边的呢 你可以在 Dialog 内容区域自己做间距控制 |
|
@bindoon 改成向前兼容的模式了，即使用户配了不要下边距也不会影响。 之所以不在内容区域做控制，是为了整个主题能作为一个开箱即用的设计规范给开发者用。起码要让主题网站的实例能和设计稿保持一致。而主题网站是不支持自己去配置内容的，看起来就会有问题。这个主题未来是要给整个国际站用的，设计师希望这个主题能够有比较高的完成度。 |
|
确认加 padding 能达到你要的效果吗？ |
bindoon
reviewed
Mar 17, 2022
| @@ -164,6 +171,9 @@ | |||
| #{$dialog-prefix}-header + #{$dialog-prefix}-body { | |||
| padding: $dialog-content-padding-top $dialog-content-padding-left-right $dialog-content-padding-bottom $dialog-content-padding-left-right; | |||
| } | |||
| #{$dialog-prefix}-header + #{$dialog-prefix}-body-no-footer { | |||
| padding: $dialog-content-padding-top $dialog-content-padding-left-right $dialog-content-padding-bottom-no-footer $dialog-content-padding-left-right; | |||
|
如果期望留着底边是不是可以 footer={[]} 把两个按钮去掉？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
没有 footer 时，给
.next-dialog-body增加一个类.next-dialog-body-no-footer。这个类的 padding-bottom 会使用一个新的变量$dialog-content-padding-bottom-no-footer，可供定制。默认值和原有的$dialog-content-padding-bottom一致，保证向前兼容。Fix #3799