Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using // sass comments in scss #3591

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

ClarkXia
Copy link

@ClarkXia ClarkXia commented Dec 3, 2021

sass support syntaxes of comments in two ways:

  • comments defined using /* */ that are (usually) compiled to CSS
  • comments defined using // that are not

it will be nice to use // syntaxes while it do not compiled to CSS, it may cause some strange behavior while compile css in postcss

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #3591 (3f4fd3c) into master (e20df59) will not change coverage.
The diff coverage is n/a.

❗ Current head 3f4fd3c differs from pull request most recent head d43ea23. Consider uploading reports for the commit d43ea23 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3591   +/-   ##
=======================================
  Coverage   90.63%   90.63%           
=======================================
  Files         302      302           
  Lines       17782    17782           
  Branches     5378     5378           
=======================================
  Hits        16116    16116           
  Misses       1647     1647           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e20df59...d43ea23. Read the comment docs.

@lakerswgq lakerswgq self-requested a review December 6, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants