Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Menu): value in selectedKeys doesn't exit in k2n #1015

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

youluna
Copy link
Member

@youluna youluna commented Aug 14, 2019

No description provided.

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #1015 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   91.41%   91.41%   +<.01%     
==========================================
  Files         248      248              
  Lines       14436    14439       +3     
  Branches     4565     4565              
==========================================
+ Hits        13196    13199       +3     
  Misses       1221     1221              
  Partials       19       19
Impacted Files Coverage Δ
src/menu/view/popup-item.jsx 92.85% <100%> (+0.06%) ⬆️
src/menu/view/menu.jsx 89.18% <100%> (+0.02%) ⬆️
src/menu/view/sub-menu.jsx 93.61% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9138cc3...2c94f68. Read the comment docs.

@youluna youluna force-pushed the hotfix-menu-childselectedkeys branch from 6e2bdac to fef80cd Compare August 14, 2019 14:56
Copy link
Member

@jinchanz jinchanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@youluna youluna merged commit 567469f into master Aug 15, 2019
@youluna youluna deleted the hotfix-menu-childselectedkeys branch August 21, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants