Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog]已经设置了overlayProps={{ disableScroll: false }}，但dialog显示时页面仍不能滚动 #954

Closed
Alex-xd opened this issue Aug 2, 2019 · 2 comments
Closed

[Dialog]已经设置了overlayProps={{ disableScroll: false }}，但dialog显示时页面仍不能滚动 #954

Alex-xd opened this issue Aug 2, 2019 · 2 comments
Assignees
@jdkahn

Comments

@Alex-xd
Copy link

Alex-xd commented Aug 2, 2019

Component

Dialog

Reproduction link

https://codepen.io/anon/pen/RXZeYX?&editable=true&editors=0010#anon-login

Steps to reproduce

dialog显示时，页面不能滚动。设置了overlayProps={{ disableScroll: false }}无效
@youluna
Copy link
Member

youluna commented Aug 5, 2019 •
edited
Loading

在Dialog的模式下，禁用页面滚动是必要的，什么情况会需要让页面滚动呢？

@Alex-xd
Copy link
Author

Alex-xd commented Aug 7, 2019

在Dialog的模式下，禁用页面滚动是必要的，什么情况会需要让页面滚动呢？

关闭了mask，弹窗在屏幕的右上角出现，弹窗里的内容是一个反馈问卷，所以这种场景下弹窗阻塞了页面的正常滚动就有问题啦。但是我不用弹窗的话，就只能自己用Overlay去封装一个一摸一样的弹窗.. @youluna

youluna added a commit that referenced this issue Aug 28, 2019
@youluna
Merge pull request #1054 from jdkahn/issue/954
0d6e4ce 
fix(Dialog): allow disableScroll. fix #954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdkahn jdkahn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youluna @Alex-xd @jdkahn